fix: remove duplicate ruff entry from Code Linters section#3119
Open
AG141293 wants to merge 2 commits intovinta:masterfrom
Open
fix: remove duplicate ruff entry from Code Linters section#3119AG141293 wants to merge 2 commits intovinta:masterfrom
AG141293 wants to merge 2 commits intovinta:masterfrom
Conversation
ruff was listed twice — under both Code Linters and Code Formatters. Removed the duplicate from Code Linters since Ruff belongs More accurately, under Code Formatters.
JinyangWang27
requested changes
May 9, 2026
Collaborator
JinyangWang27
left a comment
JinyangWang27
left a comment
There was a problem hiding this comment.
Subsection formatter got accidentally removed, can you add it back?
There are two new blank empty lines added at the end of the list, please remove them.
Once the git diff shows just 1 line removed, it will be ready to merge!
Author
|
@JinyangWang27 Fixed! Restored the subheading and removed trailing blank lines. Please take another look. |
JinyangWang27
requested changes
May 9, 2026
Collaborator
JinyangWang27
left a comment
JinyangWang27
left a comment
There was a problem hiding this comment.
In the second commit, ruff got removed from Code formatter. Please make sure that in file change view, git diff only shows 1 line deletion on l607, which was the ruff in linter section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ruffwas listed twice in the Code Analysis section:Fix
Removed the duplicate entry from Code Linters.
"Ruff" is already listed under Code Formatters, where it belongs.